add test to github workflow #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-renaud-okta
approved these changes
Aug 2, 2024
david-renaud-okta
approved these changes
Aug 5, 2024
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| W3C XML Encryption implementation for node.js (http://www.w3.org/TR/xmlenc-core/) | |||
|
|
|||
| Supports node >= 12 | |||
| Supports node >= 12 < 18 | |||
There was a problem hiding this comment.
We should address the Triple DES issues instead of dropping support for Node 18. We likely don't need to support that algorithm at all
There was a problem hiding this comment.
Agreed. This is more for backwards compatibility reasons. A drop in algorithm will require a major version bump.
lzychowski
reviewed
Aug 5, 2024
lzychowski
previously approved these changes
Aug 5, 2024
lzychowski
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test runs during PR merge.
Also updated the README on node version support.
References
Node 18 does not support triple des algorithm (listed as insecure) due to